Skip to content

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Mar 18, 2025

some minor improvement related to mercure and JS logic (I use both with stimulus)

@xabbuh
Copy link
Member

xabbuh commented Mar 18, 2025

For 6.4?

@javiereguiluz javiereguiluz added this to the 6.4 milestone Mar 18, 2025
@carsonbot carsonbot changed the title Update mercure.rst [Mercure] Update mercure.rst Mar 18, 2025
@javiereguiluz javiereguiluz changed the base branch from 7.2 to 6.4 March 18, 2025 12:45
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner March 18, 2025 12:45
@javiereguiluz javiereguiluz merged commit b7ed6f9 into symfony:6.4 Mar 18, 2025
3 checks passed
'https://example.com/books/1',
json_encode(['status' => 'OutOfStock']),
true // private
private: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted this change while merging. Unfortunately, using named arguments in PHP code samples is forbidden in Symfony Docs. The reason is that the name of the arguments can change, so the examples wouldn't be backwards compatible.

@javiereguiluz
Copy link
Member

Thanks Antoine!

This was merged in 6.4 and up.

@94noni
Copy link
Contributor Author

94noni commented Mar 18, 2025

oki for 6.4 thx
and i understand as well for the named parameter 👍🏻

@94noni 94noni deleted the patch-15 branch March 18, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants